Why does load_external_function() return PGFunction?

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Why does load_external_function() return PGFunction?
Date: 2018-02-06 20:02:05
Message-ID: 20180206200205.f5kvbyn6jawtzi6s@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

We've several callers to load_external_function() that do not use the
returned value as a PGFunction. I'd vote for changing the return type to
void * and have fmgr.c cast it to PGFunction after verifying the
function's magic.

Greetings,

Andres Freund

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-06 20:11:12 Re: RelOptInfo -> Relation
Previous Message Robert Haas 2018-02-06 19:25:04 pgsql: Avoid valgrind complaint about write() of uninitalized bytes.