Re: [HACKERS] Custom compression methods

From: Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>
To: Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Евгений Шишкин <itparanoia(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Chapman Flack <chap(at)anastigmatix(dot)net>
Subject: Re: [HACKERS] Custom compression methods
Date: 2018-02-06 10:47:31
Message-ID: 20180206134731.4ba75fb8@wp.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, 29 Jan 2018 17:29:29 +0300
Ildar Musin <i(dot)musin(at)postgrespro(dot)ru> wrote:

> Hello Ildus,
>
> On 29.01.2018 14:44, Ildus Kurbangaliev wrote:
> >
> > Thanks! Attached new version of the patch.
> >
>
> Patch applies cleanly, builds without any warnings, documentation
> builds ok, all tests pass.
>
> A remark for the committers. The patch is quite big, so I really wish
> more reviewers looked into it for more comprehensive review. Also a
> native english speaker should check the documentation and comments.
> Another thing is that tests don't cover cmdrop method because the
> built-in pglz compression doesn't use it (I know there is an jsonbd
> extension [1] based on this patch and which should benefit from
> cmdrop method, but it doesn't test it either yet).
>
> I think I did what I could and so passing this patch to committers
> for the review. Changed status to "Ready for committer".
>
>
> [1] https://github.com/postgrespro/jsonbd
>

Attached rebased version of the patch so it can be applied to current
master.

--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
custom_compression_methods_v12.patch text/x-patch 328.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikhil Sontakke 2018-02-06 12:20:40 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Kyotaro HORIGUCHI 2018-02-06 10:41:23 Re: Query running for very long time (server hanged) with parallel append