|From:||Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>|
|To:||Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>|
|Subject:||Re: Flexible configuration for full-text search|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Thank you for the review!
> 1. There are no comments for some procedures, their arguments and
> return values. Ditto regarding structures and their fields.
> 2. Please, fix the year in the copyright messages from 2017 to 2018.
Both issues are fixed.
> 3. Somehow I doubt that current amount of tests covers most of the
> functionality. Are you sure that if we run lcov, it will not show
> that most of the new code is never executed during make
I checked it and most of the new code is executed (I mostly checked
ts_parse.c and ts_configmap.c because those files contain most of the
potentially unchecked code). I have added some tests to test output of
the configurations. Also, I have added a test of TEXT CONFIGURATION into
unaccent contrib to test the MAP operator.
> 4. I'm a bit concerned regarding change of the catalog in the
> src/include/catalog/indexing.h file. Are you sure it will not break
> if I migrate from PostgreSQL 10 to PostgreSQL 11?
I have tested an upgrade process via pg_upgrade from PostgreSQL 10 and
PostgreSQL 9.6 and have found a bug in a way the pg_dump generates
schema dump for old databases. I fixed it and now pg_upgrade works fine.
The new version of the patch is in an attachment.
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
|Next Message||Tom Lane||2018-02-02 14:26:54||Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)|
|Previous Message||Claudio Freire||2018-02-02 14:13:35||Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently|