Re: Transform for pl/perl

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Transform for pl/perl
Date: 2018-01-31 10:36:22
Message-ID: 20180131103621.GA19345@zakirov.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Fri, Jan 12, 2018 at 11:47:39AM +0300, Anthony Bykov wrote:
> Hello, thank you for your message.
> The problem was that different perl compilers uses different infinity
> representations. Some of them use "Inf" others - use "inf". So, in
> attachments there is a new version of the patch.

I've noticed a possible bug:

> + /* json key in v */
> + key = pstrdup(v.val.string.val);
> + keyLength = v.val.string.len;
> + JsonbIteratorNext(&it, &v, true);

I think it is worth to use pnstrdup() here, because v.val.string.val is
not necessarily null-terminated as the comment says:

> struct JsonbValue
> ...
> struct
> {
> int len;
> char *val; /* Not necessarily null-terminated */
> } string; /* String primitive type */

Consider an example:

=# CREATE FUNCTION testSVToJsonb3(val jsonb) RETURNS jsonb
AS $$
return $_->{"1"};

=# SELECT testSVToJsonb3('{"1":{"2":[3,4,5]},"2":3}');

But my perl isn't good, so the example maybe isn't good too.

Arthur Zakirov
Postgres Professional:
Russian Postgres Company

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Gaddam Sai Ram 2018-01-31 10:51:01 Re: Help needed in using 'on_dsm_detach' callback
Previous Message Amit Kapila 2018-01-31 08:57:10 Re: Wait for parallel workers to attach