From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: JIT compiling with LLVM v9.0 |
Date: | 2018-01-24 22:42:12 |
Message-ID: | 20180124224212.sfdv5x55stnnwz7b@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2018-01-24 14:06:30 -0800, Andres Freund wrote:
> > In LLVM 5.0, it looks like DebugInfo.h is not available in llvm-c, only as a C
> > ++ API in llvm/IR/DebugInfo.h.
>
> Hm, I compiled against 5.0 quite recently, but added the stripping of
> debuginfo lateron. I'll add a fallback method, thanks for pointing that
> out!
Went more with your fix, there's not much point in using the C API
here. Should probably remove the use of it nearly entirely from the .cpp
file (save for wrap/unwrap() use). But man, the 'class Error' usage is
one major ugly pain.
> > But I still could not build because the LLVM API changed between 5.0 and 6.0
> > regarding value info SummaryList.
>
> Hm, thought these changes were from before my 5.0 test. But the code
> evolved heavily, so I might misremember. Let me see.
Ah, that one was actually easier to fix. There's no need to get the base
object at all, so it's just a one-line change.
> Thanks, I'll try to push fixes into the tree soon-ish..
Pushed.
Thanks again for looking!
- Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2018-01-24 22:51:43 | Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump |
Previous Message | Andres Freund | 2018-01-24 22:06:30 | Re: JIT compiling with LLVM v9.0 |