Re: pgsql: Add parallel-aware hash joins.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add parallel-aware hash joins.
Date: 2018-01-24 21:29:16
Message-ID: 20180124212916.aufzppm5bzg3oxav@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2018-01-22 23:17:47 +1300, Thomas Munro wrote:
> On Thu, Dec 28, 2017 at 5:26 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Here is a patch that halves the size of the test tables used. I don't
> want them to be too small because I want some some real parallel
> processing at least sometimes. On my slowest system with assertions
> enabled this brings "time make check" from ~37.5s to ~36.9s. I'm a
> bit worried about choosing parameters that lead to instability across
> the buildfarm, until I make the size estimation code a bit smarter[1],
> so I tested a few variations that affect the alignment and size of
> things (-m32, -malign-double, --disable-atomics, --disable-spinlocks)
> and didn't see failures. Does this pass repeatedly on gaur?

I'd say, let's just commit it and see?

Will do so soon if nobody protests.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-01-24 21:39:44 pgsql: Avoid referencing off the end of subplan_partition_offsets.
Previous Message Robert Haas 2018-01-24 21:09:56 Re: pgsql: Add parallel-aware hash joins.

Browse pgsql-hackers by date

  From Date Subject
Next Message Pierre Ducroquet 2018-01-24 21:35:08 Re: JIT compiling with LLVM v9.0
Previous Message David Steele 2018-01-24 21:23:12 Re: PATCH: Exclude unlogged tables from base backups