| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
| Subject: | Re: [HACKERS] Proposal: Local indexes for partitioned table |
| Date: | 2018-01-18 21:43:59 |
| Message-ID: | 20180118214359.w3ojltwyms5n4m5o@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's a patch to add pg_dump tests. This verifies that the
CREATE INDEX on parent and partition appear, as well as ALTER INDEX ..
ATTACH PARTITION.
While doing this, I noticed a small bug: the ALTER INDEX would not be
dumped when only one of the schemas are specified to pg_dump (schema of
parent and schema of partition), but it would be if both were specified.
This patch fixes that problem too. AFAICS the test is correct after
that fix (ie. the "like" and "unlike" sets are correct now.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-tests-for-pg_dump-fix-minor-bug-discovered-while.patch | text/plain | 5.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-01-18 22:09:19 | Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall |
| Previous Message | Robert Haas | 2018-01-18 21:34:31 | Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall |