Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Lætitia Avrot <laetitia(dot)avrot(at)gmail(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis
Date: 2018-01-15 01:32:20
Message-ID: 20180115013220.GE2416@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings Lætitia, Amit,

* Lætitia Avrot (laetitia(dot)avrot(at)gmail(dot)com) wrote:
> Thanks Stephen for the suggestion. I wan't thinking globally enough. I was
> planning to look at it today but Amit was faster. So thanks Amit too!

This seems to have gotten lost in the shuffle, but Amit's patch still
applies cleanly and it looks like a good patch to me, so I've added it
to the current CF and marked it as Needs Review. There's been some
further discussion of this change over in this thread:

https://www.postgresql.org/message-id/flat/20171220090816(dot)25744(dot)72592%40wrigleys(dot)postgresql(dot)org#20171220090816(dot)25744(dot)72592(at)wrigleys(dot)postgresql(dot)org

which seemed to reach the conclusion that the proposed patch makes
sense.

If someone else would like to review it, that'd be great, otherwise I'll
probably get it committed soon.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-01-15 01:33:41 Re: [HACKERS] Refactoring identifier checks to consistently use strcmp
Previous Message Andres Freund 2018-01-15 01:20:08 Re: PATCH: psql tab completion for SELECT