Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Christophe Pettus <christophe(dot)pettus(at)pgexperts(dot)com>, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?
Date: 2018-01-12 22:06:12
Message-ID: 20180112220612.jvblkkumiifb5355@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2018-01-12 07:51:34 -0500, Robert Haas wrote:
> On Thu, Jan 11, 2018 at 11:01 PM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> > Are you saying we should do the work now to create a per-transaction
> > DSM segment + DSA area + thing that every backend attaches to?
>
> No, I was just thinking you could stuff it into the per-parallel-query
> DSM/DSA. But...
>
> > I didn't think creating backend local hash tables would be a problem
> > because it's a vanishingly rare occurrence for the hash table to be
> > created at all (ie when you've altered an enum), and if created, to
> > have more than a couple of entries in it.
>
> ...this is also a fair point.

OTOH, it seems quite likely that we'll add more transaction-lifetime
shared data (e.g. combocid), so building per-xact infrastructure
actually seems like a good idea.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2018-01-13 02:42:49 Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?
Previous Message Tom Lane 2018-01-12 21:55:17 Re: [BUGS] BUG #14890: Error grouping by same column twice using FDW

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-01-12 22:19:42 Re: WIP: a way forward on bootstrap data
Previous Message Andres Freund 2018-01-12 21:58:58 Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation()