Re: add queryEnv to ExplainOneQuery_hook

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add queryEnv to ExplainOneQuery_hook
Date: 2018-01-12 02:08:18
Message-ID: 20180112020818.GE2222@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 12, 2018 at 10:43:40AM +0900, Tatsuro Yamada wrote:
> Thanks guys! :)
>
> I also surprised that there is no complaint from extension creators.
> I suppose that if possible, it would be better to create a unit test
> for the hook function to avoid the same bug because there is no contrib
> module using ExplainOneQuery_hook in contrib directory.
> (It might unnecessary thing, maybe.)

Patches welcome if you can come up with a simple concept that proves to
be useful as a template example and has some useful application cases so
as this stuff is stressed a bit by regression tests.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-01-12 02:14:14 Re: Add default role 'pg_access_server_files'
Previous Message Michael Paquier 2018-01-12 02:01:59 Re: [HACKERS] Cache lookup errors with functions manipulation object addresses