| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add queryEnv to ExplainOneQuery_hook |
| Date: | 2018-01-11 12:46:50 |
| Message-ID: | 20180111124650.GA15734@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 12, 2018 at 12:43:22AM +1300, Thomas Munro wrote:
> Yeah, I think you're right. That's an oversight in 18ce3a4a.
+1.
> I'm surprised we haven't heard any complaints sooner if there are
> advisors using that hook[1] and expecting to be able to forward to
> ExplainOnePlan(), but I suppose it would nearly always works to call
> ExplainOnePlan() with NULL as queryEnv. It'd currently only be
> non-NULL for trigger functions running SQL to access transition
> tables, which is a bit obscure: you'd need to run EXPLAIN inside a
> suitable trigger function (though in future there might be more ways
> to create named tuplestore relations).
It seems to me that QueryEnv should be pushed to the hook, but only on
HEAD. You surely don't want to break people's extensions after a minor
upgrade.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-01-11 12:47:42 | Re: [HACKERS] Creating backup history files for backups taken from standbys |
| Previous Message | Sergei Kornilov | 2018-01-11 12:44:44 | Re: numeric regression test passes, but why? |