| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| Date: | 2018-01-05 19:24:54 |
| Message-ID: | 20180105192454.GA15186@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote:
> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > pg_upgrade: simplify code layout in a few places
> >
> > Backpatch-through: 9.4 (9.3 didn't need improving)
>
> Hmm. We don't normally do things like this, because it breaks translatability.
Oh, you mean the 'if()' statement? If so, I will revert that and add a
comment so I don't do it again in that place.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-05 19:31:51 | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| Previous Message | Robert Haas | 2018-01-05 19:20:59 | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-01-05 19:28:29 | Re: BUGFIX: standby disconnect can corrupt serialized reorder buffers |
| Previous Message | Robert Haas | 2018-01-05 19:20:59 | Re: pgsql: pg_upgrade: simplify code layout in a few places |