Re: [Patch v2] Make block and file size for WAL and relations defined at cluster creation

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Remi Colinet <remi(dot)colinet(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Patch v2] Make block and file size for WAL and relations defined at cluster creation
Date: 2018-01-03 22:11:00
Message-ID: 20180103221100.riszh4c3m2omor5r@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Remi Colinet wrote:
> Hello,
>
> This is version 2 of the patch to make the file and block sizes for WAL and
> relations, run-time configurable at initdb.

I don't think this works, since we have a rule that pallocs are
prohibited within critical section and I see that your patch changes
some stack-allocated variables to palloc'ed. For example I think the
heap_page_prune changes should break some test or other.

This patch is too massive to review.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-01-03 22:14:08 Re: [PATCH] Comment typo in get_collation_name() comment
Previous Message Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= 2018-01-03 21:58:27 Re: [PATCH] Comment typo in get_collation_name() comment