From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix deadlock hazard in CREATE INDEX CONCURRENTLY |
Date: | 2018-01-03 15:09:56 |
Message-ID: | 20180103150956.43cmmo73ctv4v237@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Actually, so far only 9.6 and up have failed. Maybe the old
> > isolationtester is different enough that the other thing doesn't happen.
>
> > I'm more inclined now to add the alternate file instead of the other
> > patch.
>
> Meh. I'd rather have the more stable test going forward; I think
> alternate expected-files too easily hide unexpected behavior. We could
> try leaving 9.4/9.5 alone and see if it's true that it doesn't fail
> there. If not, I wouldn't mind losing the test in those branches
> --- it's mainly intended to catch future breakage, after all.
Makes sense. Pushed to 9.6 and up.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-01-03 15:14:24 | pgsql: Allow ldaps when using ldap authentication |
Previous Message | Alvaro Herrera | 2018-01-03 15:09:21 | pgsql: Fix isolation test to be less timing-dependent |