Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl
Date: 2017-12-21 14:18:03
Message-ID: 20171221141803.gw37udxcozd3smys@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christoph Berg wrote:
> Re: Andrew Dunstan 2017-12-21 <d68d254a-6f97-a8c2-4656-ab8886fe2c38(at)2ndQuadrant(dot)com>

> > I've found it annoying in the past. Probably now that the buildfarm
> > reports each test series separately it matters less. Previously we
> > reported many of the TAP tests together.
>
> Rename them to the directory name:
>
> ./src/bin/pg_rewind/t/001_pg_rewind.pl
> ./src/test/modules/commit_ts/t/001_commit_ts.pl
> ./src/test/modules/test_pg_dump/t/001_test_pg_dump.pl

These sound good to me.

> ./src/bin/pg_dump/t/001_pg_dump.pl

There already is t/002_pg_dump.pl. src/bin/pg_dump/t/001_basic.pl is
all about command lines, perhaps we can find a name that evokes that --
001_dump_cmdline.pl? (prefixed "_dump_" to be in line with
t/010_dump_connstr.pl)

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-12-21 14:19:16 Re: domain cast in parameterized vs. non-parameterized query
Previous Message Amit Kapila 2017-12-21 14:13:28 Re: [HACKERS] parallel.c oblivion of worker-startup failures