Re: pgbench's expression parsing & negative numbers

From: Andres Freund <andres(at)anarazel(dot)de>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench's expression parsing & negative numbers
Date: 2017-12-14 20:26:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2017-12-14 10:41:04 +0100, Fabien COELHO wrote:
> - I do not think that updating pgbench arithmetic for managing integer
> overflows is worth Andres Freund time. My guess is that most
> script would not trigger client-side overflows, so the change would
> be a no-op in practice.

It might not be if you view it in isolation (although I'm not
convinced). The problem is that it has cost beyond pgbench. Due to
pgbench's overflow handling I can't run make check on a build that has
-ftrapv, which found several bugs already.

I'd be happy if somebody else would tackle the issue, but I don't quite
see it happening...


Andres Freund

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-12-14 20:38:03 Re: pgsql: Provide overflow safe integer math inline functions.
Previous Message Peter Geoghegan 2017-12-14 20:06:26 Re: PostgreSQL crashes with SIGSEGV