Re: pgsql: Add hooks for session start and session end

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add hooks for session start and session end
Date: 2017-11-16 12:18:23
Message-ID: 20171116121823.GI4628@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Greetings,

* Andrew Dunstan (andrew(dot)dunstan(at)2ndquadrant(dot)com) wrote:
> On 11/15/2017 04:30 PM, Tom Lane wrote:
> > Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> >> Maybe we need to shift from installcheck to check mode for these
> >> modules. That would involve a buildfarm script change.
> > Seems like expending an awful lot of cycles in support of a rather trivial
> > feature.
>
> Possibly. At any rate I'm not going to do it immediately.

This is something that's bitten us a few times with various test
modules, so I don't think that effort would be wasted.

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2017-11-16 13:14:51 Re: pgsql: Disable installcheck tests for test_session_hooks
Previous Message Michael Paquier 2017-11-16 06:45:35 Re: pgsql: Disable installcheck tests for test_session_hooks

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-11-16 12:40:44 Re: Further simplification of c.h's #include section
Previous Message Masahiko Sawada 2017-11-16 12:15:01 Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile