Re: [COMMITTERS] pgsql: Implement table partitioning.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Implement table partitioning.
Date: 2017-10-18 08:53:23
Message-ID: 20171018085323.4pi7qn5r3igjfmmn@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

Amit Langote wrote:
> On 2017/10/18 1:52, Alvaro Herrera wrote:
> > Alvaro Herrera wrote:
> >> Robert Haas wrote:
> >>> Implement table partitioning.
> >>
> >> Is it intentional that you can use ALTER TABLE OWNER TO on the parent
> >> table, and that this does not recurse to modify the partitions' owners?
> >> This doesn't seem to be mentioned in comments nor documentation, so it
> >> seems an oversight to me.
>
> Hmm, I would say of it that the new partitioning didn't modify the
> behavior that existed for inheritance.
>
> That said, I'm not sure if the lack of recursive application of ownership
> change to descendant tables is unintentional.

My view is that the fact that partitioning uses inheritance is just an
implementation detail. We shouldn't let historical behavior for
inheritance dictate behavior for partitioning. Inheritance has many
undesirable warts.

> > The alter table docs say that ONLY must be specified if one does not
> > want to modify descendants, so I think this is a bug.
>
> Just to clarify, if we do think of it as a bug, then it will apply to the
> inheritance case as well, right?

I'd leave it alone.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Wolfgang Wilhelm 2017-10-18 10:20:50 Re: Re: Is anything preventing us from allowing write to foreign tables from standby?
Previous Message tushar 2017-10-18 08:36:04 Re: parallelize queries containing initplans

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2017-10-18 11:24:32 pgsql: Make release notes aware that --xlog-method was renamed
Previous Message Amit Langote 2017-10-18 01:00:35 Re: [COMMITTERS] pgsql: Implement table partitioning.