Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.
Date: 2017-10-13 18:01:06
Message-ID: 20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2017-10-13 13:48:07 -0400, Tom Lane wrote:
> I wrote:
> > Anyway, I will go make the sizeof() usages consistent, just to satisfy
> > my own uncontrollable neatnik-ism. Assuming that hornet stays red,
> > which is probable, we should disable "restrict" for that compiler.
>
> As expected, that didn't fix it. Andres, are you going to put in
> a disable? Do we know exactly what we want to test for that?

A easiest way to do this would be to put something like
CPPFLAGS="$CPPFLAGS -Dpg_restrict" into the existing
if test "$GCC" != yes ; then
block in a/src/template/linux. But that'd probably result in "macro
redefined" warnings or somesuch.

So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set
at the same place, that's then tested before running the relevant
configure check?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-10-13 18:19:22 Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.
Previous Message Tom Lane 2017-10-13 17:48:07 Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-10-13 18:07:54 Re: Improve catcache/syscache performance.
Previous Message Peter Geoghegan 2017-10-13 17:59:51 Re: Pluggable storage