Hi,
On 2017-10-11 10:40:11 +0900, Michael Paquier wrote:
> >> + if (conn->forced_protocol_version != NULL)
> >> + {
> >> + conn->pversion = atoi(conn->forced_protocol_version);
> >> + }
> >> This should check for strlen > 0 as well.
> >
> > Why? Note that we don't do elsehwere in fe-connect.c.
>
> Because it seems to me that the default value of the parameter should
> be an empty string instead of D. Feels more consistent with the
> others.
I'm not following. The "D" is in the 'dispchar' field, not the value
field, no? The default value is NULL?
Greetings,
Andres Freund