datetime.h defines like PM conflict with external libraries

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: datetime.h defines like PM conflict with external libraries
Date: 2017-10-03 19:00:33
Message-ID: 20171003190033.nsizxfnvgwx6frap@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In my llvm jit work I'd to

#undef PM
/* include some llvm headers */
#define PM 1

because llvm has a number of functions which have an argument named PM.
Now that works, but it's fairly ugly. Perhaps it would be a good idea to
name these defines in a manner that's slightly less likely to conflict?

Alternatively we could use #pragma push_macro() around the includes, but
that'd be a new dependency.

Better ideas?

Greetings,

Andres Freund

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-10-03 19:27:14 Re: Partition-wise join for join between (declaratively) partitioned tables
Previous Message Petr Jelinek 2017-10-03 18:32:22 Re: [sqlsmith] stuck spinlock in pg_stat_get_wal_receiver after OOM