From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add test for postmaster crash restarts. |
Date: | 2017-10-01 02:32:14 |
Message-ID: | 20171001023214.zgw3gs7mxjmlkqcd@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2017-09-30 22:28:39 -0400, Andrew Dunstan wrote:
> >> But even after fixing that, there unfortunately is:
> >>
> >> static void
> >> set_sig(char *signame)
> >> {
> >> …
> >> #if 0
> >> /* probably should NOT provide SIGKILL */
> >> else if (strcmp(signame, "KILL") == 0)
> >> sig = SIGKILL;
> >> #endif
> >>
> >> I'm unclear on what that provision is achieving? If you can kill with
> >> pg_ctl you can do other nasty stuff too (like just use kill instead of
> >> pg_ctl)?
>
>
> I put it in when we rewrote pg_ctl in C many years ago, possibly out of
> a superabundance of caution. I agree it's worth revisiting. I think the
> idea was that there's a difference between an ordinary footgun and an
> officially sanctioned footgun :-)
Heh. I'm inclined to take it out. We could add a --use-the-force-luke
type parameter, but it doesn't seem worth it.
> Haven't tested on MSVC but with this patch it passes on jacana (mingw).
Yay! Thanks for testing.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2017-10-01 06:37:42 | pgsql: Fix busy-wait in pgbench, with --rate. |
Previous Message | Andrew Dunstan | 2017-10-01 02:28:39 | Re: pgsql: Add test for postmaster crash restarts. |
From | Date | Subject | |
---|---|---|---|
Next Message | Devrim Gündüz | 2017-10-01 02:55:41 | Re: extension build issue with PostgreSQL 10 on Centos6 |
Previous Message | Andrew Dunstan | 2017-10-01 02:28:39 | Re: pgsql: Add test for postmaster crash restarts. |