| From: | Darafei Praliaskouski <me(at)komzpa(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Fedor Sigaev <teodor(at)sigaev(dot)ru>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
| Subject: | Re: compress method for spgist - 2 |
| Date: | 2017-09-20 19:00:59 |
| Message-ID: | 20170920190059.1354.29457.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed
Hi,
I like the SP-GiST part of the patch. Looking forward to it, so PostGIS can benefit from SP-GiST infrastructure.
I have some questions about the circles example though.
* What is the reason for isnan check and swap of box ordinates for circle? It wasn't in the code previously.
* There are tests for infinities in circles, but checks are for NaNs.
* It seems to me that circle can be implemented without recheck, by making direct exact calculations.
How about removing circle from the scope of this patch, so it is smaller and cleaner?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-20 19:29:35 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
| Previous Message | Peter Geoghegan | 2017-09-20 18:23:58 | Re: CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it? |