| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup. |
| Date: | 2017-09-17 08:07:52 |
| Message-ID: | 20170917080752.rcmihzfmgbeuqjk2@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2017-09-16 13:27:05 -0700, Andres Freund wrote:
> > This does not seem like a problem that justifies a system-wide change
> > that's much more delicate than you thought.
>
> We need one more initialization call during crash-restart - that doesn't
> seem particularly hard a fix.
FWIW, attached is that simple fix. Not quite ready for commit - needs
more comments, thoughts and a glass of wine less to commit.
I'll try to come up with a tap test that tests crash restarts tomorrow -
not sure if there's a decent way to trigger one on windows without
writing a C function. Will play around with that tomorrow.
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Preliminary-fix-for-crash-restart.patch | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-17 15:35:32 | pgsql: Fix bogus size calculation introduced by commit cc5f81366. |
| Previous Message | Andres Freund | 2017-09-16 20:27:05 | Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2017-09-17 08:08:11 | Re: SQL/JSON in PostgreSQL |
| Previous Message | Andreas Karlsson | 2017-09-17 01:33:59 | Re: postgres_fdw super user checks |