| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: More efficient truncation of pg_stat_activity query strings |
| Date: | 2017-09-15 20:36:32 |
| Message-ID: | 20170915203632.6eu4pggl2vowcx5r@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-09-15 08:25:09 -0400, Robert Haas wrote:
> On Thu, Sep 14, 2017 at 2:03 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Here's a patch that implements that idea.
>
> From the department of cosmetic nitpicking:
>
> + * All supported server-encodings allow to determine the length of a
>
> make it possible to determine
>
> + * multi-byte character from it's first byte (not the case for client
>
> its
>
> this is not the case
>
> + * encodings, see GB18030). As st_activity always is stored using server
>
> is always stored using a server
>
> + * pgstat_clip_activity() to trunctae correctly.
Version correcting these is attached. Thanks!
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Speedup-pgstat_report_activity-by-moving-mb-aware-tr.v2.patch | text/x-diff | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-09-15 20:40:41 | Re: The case for removing replacement selection sort |
| Previous Message | Daniel Gustafsson | 2017-09-15 20:20:01 | Re: postgres_fdw: evaluate placeholdervars on remote server |