Re: [PATCH] Improve geometric types

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: emre(at)hasegeli(dot)com
Cc: a(dot)alekseev(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Improve geometric types
Date: 2017-09-15 08:43:39
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

Hello, just one point on 0001.

The patch replace pg_hypot with hypot in libc. The man page says
as follows.

man 3 hypot
> If the result overflows, a range error occurs, and the functions return
> HUGE_VAL, HUGE_VALF, or HUGE_VALL, respectively.
> See math_error(7) for information on how to determine whether an error
> has occurred when calling these functions.
> The following errors can occur:
> Range error: result overflow
> errno is set to ERANGE. An overflow floating-point exception
> (FE_OVERFLOW) is raised.
> Range error: result underflow
> An underflow floating-point exception (FE_UNDERFLOW) is raised.
> These functions do not set errno for this case.

So, the code seems to need some amendments following to this


Kyotaro Horiguchi
NTT Open Source Software Center

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-09-15 08:50:17 Re: path toward faster partition pruning
Previous Message Rafia Sabih 2017-09-15 08:39:29 Re: Partition-wise join for join between (declaratively) partitioned tables