Re: uninterruptible state in 10beta4

From: Andres Freund <andres(at)anarazel(dot)de>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: uninterruptible state in 10beta4
Date: 2017-09-13 21:41:37
Message-ID: 20170913214137.ku6f4ciuapeg27ts@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2017-09-13 14:28:34 -0700, Jeff Janes wrote:
> In 10beta4 and 11dev, If I run the below it enters an uninterruptible
> state. After the insert starts, I give 15 or seconds or so until the
> memory usage starts to grow due to enqueued triggers checks. Then I can't
> interrupt it with either ctrl-C in psql or kill -15 <pid> from another
> terminal.
>
> I have to do kill -9 <pid>
>
> create table foo (x int);
> create or replace function notice () returns trigger as $$ begin raise
> notice 'asdfsdf'; return NEW; END;$$ language plpgsql;
> create trigger foobar after insert on foo for each row execute procedure
> notice();
> insert into foo select * from generate_series(1,100000000);
>
> Git bisect lays the blame here which certainly seems plausible:
>
> commit d47cfef7116fb36349949f5c757aa2112c249804
> Author: Andres Freund <andres(at)anarazel(dot)de>
> Date: Tue Jul 25 17:37:17 2017 -0700
>
> Move interrupt checking from ExecProcNode() to executor nodes.

Indeed that seems plausible. I guess something like the attached should
fix the issue?

Greetings,

Andres Freund

Attachment Content-Type Size
cfi.diff text/x-diff 524 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2017-09-13 21:46:08 Re: uninterruptible state in 10beta4
Previous Message Thomas Munro 2017-09-13 21:36:32 Re: proposal: psql: check env variable PSQL_PAGER