Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Date: 2017-09-07 07:22:17
Message-ID: 20170907072217.j4cvrjizivn7mnrd@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut wrote:
> On 9/4/17 06:03, Alvaro Herrera wrote:
> > Tom Lane wrote:
> >> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> >>> I don't like breaking the abstraction of pg_log() with the existing
> >>> flags with some kind of pg_debug() layer. The set of APIs present now
> >>> in pg_rewind for logging is nice to have, and I think that those debug
> >>> messages should be translated. So what about the attached?
> >>
> >> Your point about INT64_FORMAT not necessarily working with fprintf
> >> is an outstanding reason not to keep it like it is. I've not reviewed
> >> this patch in detail but I think this is basically the way to fix it.
> >
> > Actually this code goes throgh vsnprintf, not fprintf, which should be
> > safe, so I removed that part of the comment, and pushed.
> Is there a reason this was not backpatched to 9.5?

No, I'll backpatch later.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2017-09-07 09:41:31 pgsql: Fix translatable string
Previous Message Peter Eisentraut 2017-09-07 02:37:02 Re: pgsql: Remove endof macro

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2017-09-07 07:30:45 Re: Making clausesel.c Smarter
Previous Message Chris Travers 2017-09-07 07:21:21 Re: Proposal: pg_rewind to skip config files