Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)?

On 2017-09-06 17:36:02 +0900, Kyotaro HORIGUCHI wrote:
> Hi,
>
> At Mon, 4 Sep 2017 17:17:19 +0900, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqSPf0qkq=DhSO-tAM9++LSA2aEYSVJ3oY_EdUdb=jKi1w(at)mail(dot)gmail(dot)com>
> > On Mon, Sep 4, 2017 at 4:04 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > I've not read through the thread, but this seems like the wrong approach
> > > to me. The receiving side should use a correct value, instead of putting
> > > this complexity on the sender's side.
> >
> > Yes I agree with that. The current patch gives me a bad feeling to be
> > honest with the way it does things..
>
> The problem is that the current ReadRecord needs the first one of
> a series of continuation records from the same source with the
> other part, the master in the case.

What's the problem with that? We can easily keep track of the beginning
of a record, and only confirm the address before that.

> A (or the) solution closed in the standby side is allowing to
> read a seris of continuation records from muliple sources.

I'm not following. All we need to use is the beginning of the relevant
records, that's easy enough to keep track of. We don't need to read the
WAL or anything.

- Andres