Re: Regression stoping PostgreSQL 9.4.13 if a walsender is running

From: Andres Freund <andres(at)anarazel(dot)de>
To: Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Regression stoping PostgreSQL 9.4.13 if a walsender is running
Date: 2017-08-24 22:22:35
Message-ID: 20170824222235.qflyaobzws25mrgh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2017-08-22 19:28:22 +0200, Marco Nenciarini wrote:
> I have noticed that after the 9.4.13 release PostgreSQL reliably fails
> to shutdown with smart and fast method if there is a running walsender.
>
> The postmaster continues waiting forever for the walsender termination.
>
> It works perfectly with all the other major releases.
>
> I bisected the issue to commit 1cdc0ab9c180222a94e1ea11402e728688ddc37d
>
> After some investigation I discovered that the instruction that sets
> got_SIGUSR2 was lost during the backpatch in the WalSndLastCycleHandler
> function.
>
> The trivial patch is the following:

Pushed, thanks! And sorry again.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-08-24 22:23:02 Re: MCXT_ALLOC_NO_OOM -> DSA_ALLOC_NO_OOM in dsa.c
Previous Message Andres Freund 2017-08-24 22:22:14 pgsql: Fix bug that can cause walsender not to terminating at shutdown.