| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Log LDAP "diagnostic messages"? |
| Date: | 2017-08-15 16:08:08 |
| Message-ID: | 20170815160807.qpjvk4ta5iuudezh@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Re: Thomas Munro 2017-08-10 <CAEepm=09jnV7hK5rTxPp816bMuve7dJGbjtEcjeXrhAELHFxqw(at)mail(dot)gmail(dot)com>
> > Agreed. Here's a version that skips those useless detail messages
> > using a coding pattern I found elsewhere.
>
> Rebased after bf6b9e94.
> message ? errdetail("Diagnostic message: %s", message) : 0));
"Diagnostic message" doesn't really mean anything, and printing
"DETAIL: Diagnostic message: <something>" seems redundant to me. Maybe
drop that prefix? It should be clear from the context that this is a
message from the LDAP layer.
Or maybe simply append ": <message>" to the error message already shown?
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-15 16:28:46 | pgsql: Simplify plpgsql's check for simple expressions. |
| Previous Message | Tom Lane | 2017-08-15 15:24:23 | Re: [HACKERS] Replication to Postgres 10 on Windows is broken |