Re: Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events
Date: 2017-08-09 15:18:37
Message-ID: 20170809151837.GF10454@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Aug 09, 2017 at 10:56:50AM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> >>> As for whether hypothetical check scripts would ever be run, I
> >>> was thinking we should stick them under some make target that
> >>> developers run all the time anyway -- perhaps "check".
> >>> Shouldn't we catch simple mechanically detectable problems as
> >>> early in the pipeline as possible?
>
> >> Adding overhead to every developer's every test cycle doesn't
> >> sound like a win.
>
> > If it takes 100ms, nobody's gonna notice.
>
> I doubt running a perl script that analyzes the entire backend
> source code is gonna take 100ms.

What would be a reasonable maximum amount of time for such a check to take?

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-08-09 16:06:23 pgsql: Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make to GN
Previous Message Tom Lane 2017-08-09 14:56:50 Re: Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-09 15:25:34 Re: "make check" with non-GNU make
Previous Message Tom Lane 2017-08-09 14:56:50 Re: Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events