| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: More race conditions in logical replication |
| Date: | 2017-07-27 17:51:03 |
| Message-ID: | 20170727175103.m6v5aj7iwhb7rcis@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Alvaro Herrera wrote:
>
> > Hmm, yeah, that's not good. However, I didn't like the idea of putting
> > it inside the locked area, as it's too much code. Instead I added just
> > before acquiring the spinlock. We cancel the sleep unconditionally
> > later on if we didn't need to sleep after all.
>
> I just noticed that Jacana failed again in the subscription test, and it
> looks like it's related to this. I'll take a look tomorrow if no one
> beats me to it.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2017-07-26%2014%3A39%3A54
Ahh, I misread the message. This one is actually about the replication
*origin* being still active, not the replication *slot*. I suppose
origins need the same treatment as we just did for slots. Anybody wants
to volunteer a patch?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-07-27 18:13:51 | Re: tab completion for "create user mapping for" |
| Previous Message | Tom Lane | 2017-07-27 17:40:00 | Re: psql's \d and \dt are sending their complaints to different output files |