Re: Locale dependency in new postgres_fdw test

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Locale dependency in new postgres_fdw test
Date: 2017-07-21 19:35:28
Message-ID: 20170721193528.ao3adbv4cvesywdf@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> We could stabilize this test result by forcing lc_messages = C in
> the foreign server options. However, that would lose regression
> coverage of situations where the remote locale is different, which
> doesn't seem like a terribly good thing.

I don't understand what is the benefit of having a different locale
setting if there's no way that the test would pass except with a very
specific locale. In other words, what coverage are we really losing by
going this route?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2017-07-21 19:42:11 possible effective_io_concurrency performance regression
Previous Message Fabrízio de Royes Mello 2017-07-21 19:14:19 Re: [PATCH] A hook for session start