Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()
Date: 2017-07-20 13:44:25
Message-ID: 20170720224425.9e967e54.nagata@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg().
This says "Compute ID and segment from an XLogRecPtr", but these
macros compute only segment numbers. I think "Compute a segment number
from an XLogRecPtr" is correct.

The definition of these macros were modified by the following commit,
but the comment were not.

commit dfda6ebaec6763090fb78b458a979b558c50b39b
Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Date: Sun Jun 24 18:06:38 2012 +0300

Regards,

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
xlog_internal.patch text/x-diff 575 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2017-07-20 13:47:19 Re: pg_upgrade failed if view is based on sequence
Previous Message Yugo Nagata 2017-07-20 13:33:12 Re: xlogfilename