Re: Race-like failure in recovery/t/009_twophase.pl

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Race-like failure in recovery/t/009_twophase.pl
Date: 2017-07-02 15:00:30
Message-ID: 20170702150030.hxiw6br44b5vr6zk@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> Part of the reason I'm confused is that the programming technique
> being used in 009_twophase.pl, namely doing
>
> ($node_master, $node_slave) = ($node_slave, $node_master);
>
> and then working with the reversed variable names, is ENTIRELY TOO CUTE
> FOR ITS OWN GOOD.

This is my fault. I noticed this in the submitted test (and was pretty
confused about it too) when I reviewed it for commit, but somehow it
didn't reach my threshold to require a rewrite. I'll fix it sometime
during the week.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-07-02 15:54:15 Re: Race-like failure in recovery/t/009_twophase.pl
Previous Message Robert Haas 2017-07-02 11:10:06 Re: UPDATE of partition key