| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reducing pg_ctl's reaction time |
| Date: | 2017-06-28 19:44:25 |
| Message-ID: | 20170628194425.my75yb4lp5aerm7x@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> So when I removed the miscadmin.h include, I found out that pg_ctl is
> also relying on PG_BACKEND_VERSIONSTR from that file.
>
> There are at least three things we could do here:
>
> 1. Give this up as not worth this much trouble.
>
> 2. Move PG_BACKEND_VERSIONSTR into pg_config.h to go along with the
> other version-related macros.
pg_config.h sounds like a decent enough solution. It's a bit strange
this hasn't come up before, given that that symbol is used more in
frontend environ than backend.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-06-28 20:02:03 | Re: Reducing pg_ctl's reaction time |
| Previous Message | Robert Haas | 2017-06-28 19:01:29 | Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility) |