| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reducing pg_ctl's reaction time |
| Date: | 2017-06-28 17:34:57 |
| Message-ID: | 20170628173457.yhq7zmfhjdcfvkto@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-06-28 13:31:27 -0400, Tom Lane wrote:
> I'm not hearing anyone speaking against doing this now, so I'm going
> to go ahead with it.
Cool.
> While looking this over again, I got worried about the fact that pg_ctl
> is #including "miscadmin.h". That's a pretty low-level backend header
> and it wouldn't be surprising at all if somebody tried to put stuff in
> it that wouldn't compile frontend-side. I think we should take the
> opportunity, as long as we're touching this stuff, to split the #defines
> that describe the contents of postmaster.pid into a separate header file.
> Maybe "utils/pidfile.h" ?
Yes, that sounds like a valid concern, and solution.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Khandekar | 2017-06-28 17:43:03 | Re: UPDATE of partition key |
| Previous Message | Tom Lane | 2017-06-28 17:31:27 | Re: Reducing pg_ctl's reaction time |