Re: Fix a typo in README.dependencies

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: atorikoshi <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo in README.dependencies
Date: 2017-06-22 21:28:45
Message-ID: 20170622212845.x7iltj4bwphvwcbl@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ashutosh Bapat wrote:
> On Mon, Jun 5, 2017 at 8:22 AM, atorikoshi
> <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > Hi,
> >
> > I found below formula to compute selectivities, but
> > I think the last Probability 'P(b=?)' should be 'P(c=?)'.
> >
> >> P(a=?,b=?,c=?) = P(a=?,b=?) * (d + (1-d)*P(b=?))
> >
> >
> > Attached patch fixes it, and it also adds some spaces
> > following another formula which is on line 86 and
> > computes P(a=?, b=?).
>
> Agree. Also using "d" for "degree of functional dependence (b=>c) as
> well is confusing. We are already using "d" for "degree of functional
> dependence (a=>b). Here' patch to use "d'" instead of "d".

Since the surrounding text uses single quotes to talk about each letter,
I thought it was better to use a new letter (e) so that we don't require
the "prime" notation, which would end up being either inconsistent,
confusing, stupid-looking, or combinations thereof.

Also, your proposed text had a slight mistake: it's not (b=>c) that
d' is for, but (a,b=>c).

Pushed with those corrections.

Thanks for the reports and patches!

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-06-22 21:31:35 Re: Autovacuum launcher occurs error when cancelled by SIGINT
Previous Message Tomas Vondra 2017-06-22 21:27:11 Re: Pluggable storage