| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kunshchikov Vladimir <Vladimir(dot)Kunshchikov(at)infotecs(dot)ru> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [patch] pg_dump/pg_restore zerror() and strerror() mishap |
| Date: | 2017-06-22 15:40:04 |
| Message-ID: | 20170622154004.e6bcw6juk2pwhngb@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kunshchikov Vladimir wrote:
Hi,
> our testing team has noticed apparently wrong backup/restore error messages like this:
>
>
> pg_restore: [compress_io] could not read from input file: success
> pg_dump: [directory archiver] could not write to output file: success
>
>
>
> Such "success" messages are caused by calling strerror() after gzread()/gzwrite() failures.
Yeah, I've complained about this before but never got around to actually
fixing it. Thanks for the patch, I'll see about putting it on all
branches soon.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-06-22 15:42:52 | Re: GSoC 2017 Proposal for predicate locking in hash index |
| Previous Message | Alexander Korotkov | 2017-06-22 15:36:43 | Re: Challenges preventing us moving to 64 bit transaction id (XID)? |