| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Subject: | Re: Preliminary results for proposed new pgindent implementation |
| Date: | 2017-06-16 20:10:42 |
| Message-ID: | 20170616201042.GC5081@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 16, 2017 at 03:56:47PM -0400, Tom Lane wrote:
> can be. I managed to tweak bsdindent so that its output matches
> what entab would do, by dint of the attached patch, which implements
> the rule "use a space instead of a tab if the tab would only move
> one column and we don't need another tab after it". (I think entab
> is being weird with the second half of that rule, but if I remove it,
> I get circa a thousand lines of invisible whitespace changes; probably
> better not to deal with those. With no patch at all, just letting
> bsdindent do what it does now, there's circa ten thousand changed lines.)
Yeah, entab was designed to do that, via this C comment:
/*
* Is the next character going to be a tab? We do tab
* replacement in the current spot if the next char is
* going to be a tab and ignore min_spaces.
*/
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Piotr Stefaniak | 2017-06-16 20:30:21 | Re: Preliminary results for proposed new pgindent implementation |
| Previous Message | Sergey Burladyan | 2017-06-16 19:57:33 | Re: Broken hint bits (freeze) |