From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
Subject: | Re: Preliminary results for proposed new pgindent implementation |
Date: | 2017-06-16 18:54:06 |
Message-ID: | 20170616185406.jpwq6o6ghpvprxmi@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017-06-16 14:42:38 -0400, Bruce Momjian wrote:
> On Fri, Jun 16, 2017 at 02:23:00PM -0400, Tom Lane wrote:
> > Well, that's something we need to discuss. I originally argued for
> > back-patching the new rules, whatever they are (ie, run the new
> > pgindent on the back branches whenever we've agreed that the dust
> > has settled). But I'm starting to realize that that's likely to
> > be horrid for anyone who's carrying out-of-tree patches, as I know
> > a lot of packagers do for instance. We have to trade off our own
> > inconvenience in making back-patches against inconvenience to
> > people who are maintaining private patchsets.
>
> Can't they sync up to just before our pgindent commit and run pgindent
> on their own code base?
That doesn't really help that much if you have a series of patches that
you want to keep independent, e.g. because you might want to submit to
postgres. And you'll also get a bunch of annoying to resolve merge
conflicts, even if they're easier to resolve with that methodology.
- Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2017-06-16 19:04:41 | Re: Preliminary results for proposed new pgindent implementation |
Previous Message | Bruce Momjian | 2017-06-16 18:42:38 | Re: Preliminary results for proposed new pgindent implementation |