From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: logical replication and PANIC during shutdown checkpoint in publisher |
Date: | 2017-06-05 01:29:31 |
Message-ID: | 20170605012931.irjca7tzcupvvfbc@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017-06-02 17:20:23 -0700, Andres Freund wrote:
> Attached is a *preliminary* patch series implementing this. I've first
> reverted the previous patch, as otherwise backpatchable versions of the
> necessary patches would get too complicated, due to the signals used and
> such.
I went again through this, and the only real thing I found that there
was a leftover prototype in walsender.h. I've in interim worked on
backpatch versions of that series, annoying conflicts, but nothing
really problematic. The only real difference is adding SetLatch() calls
to HandleWalSndInitStopping() < 9.6, and guarding SetLatch with an if <
9.5.
As an additional patch (based on one by Petr), even though it more
belongs to
http://archives.postgresql.org/message-id/20170421014030.fdzvvvbrz4nckrow%40alap3.anarazel.de
attached is a patch unifying SIGHUP between normal and walsender
backends. This needs to be backpatched all the way. I've also attached
a second patch, again based on Petr's, that unifies SIGHUP handling
across all the remaining backends, but that's something that probably
more appropriate for v11, although I'm still tempted to commit it
earlier.
Michael, Peter, Fujii, is either of you planning to review this? I'm
planning to commit this tomorrow morning PST, unless somebody protest
till then.
- Andres
Attachment | Content-Type | Size |
---|---|---|
0001-Revert-Prevent-panic-during-shutdown-checkpoint.patch | text/x-patch | 12.8 KB |
0002-Have-walsenders-participate-in-procsignal-infrastruc.patch | text/x-patch | 2.2 KB |
0003-Prevent-possibility-of-panics-during-shutdown-checkp.patch | text/x-patch | 14.8 KB |
0004-Unify-SIGHUP-handling-between-normal-and-walsender-b.patch | text/x-patch | 7.6 KB |
0005-Wire-up-query-cancel-interrupt-for-walsender-backend.patch | text/x-patch | 1.3 KB |
0006-Use-PostgresSigHupHandler-everywhere-SIGHUP-is-handl.patch | text/x-patch | 22.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-06-05 01:30:13 | Re: Support to COMMENT ON DATABASE CURRENT_DATABASE |
Previous Message | Michael Paquier | 2017-06-05 01:28:39 | Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog |