Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x

From: Christoph Berg <myon(at)debian(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jason Petersen <jason(at)citusdata(dot)com>, pgsql-pkg-debian(at)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Date: 2017-05-30 16:52:58
Message-ID: 20170530165258.ptkt2u457wqfmqye@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-pkg-debian

Re: Andres Freund 2017-05-30 <20170530161541(dot)koj5xbvvovrrtxtd(at)alap3(dot)anarazel(dot)de>
> I think we can fix this easily enough in Citus, postgis, and whatever.
> But it's not a particularly good user/developer experience, and
> presumably is going to become more and more common. On x86 there
> shouldn't be a difference in efficiency between the two, but some others
> will see some. Given that most distributions switched to building the
> main executables with -fPIE anyway, to allow for ASLR, it seems unlikely
> that the intra extension overhead is going to be very meaningful in
> comparison.

My main point here would be that we are already setting this for all
extensions for sparc and sparc64, so s390(x) would just follow suit.

-fPIC is the default in Debian now, see the discussion starting at
https://lists.debian.org/debian-devel/2016/05/msg00028.html
including the Fedora: https://lists.debian.org/debian-devel/2016/05/msg00219.html
and Ubuntu: https://lists.debian.org/debian-devel/2016/05/msg00225.html
situation, which all do that.

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-05-30 16:56:58 Re: Segmentation fault when creating a BRIN, 10beta1
Previous Message Tom Lane 2017-05-30 16:47:20 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x

Browse pgsql-pkg-debian by date

  From Date Subject
Next Message Tom Lane 2017-05-30 17:04:06 Re: [PATCH] relocation truncated to fit: citus build failure on s390x
Previous Message Tom Lane 2017-05-30 16:47:20 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x