| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Code review focused on new node types added by partitioning supp |
| Date: | 2017-05-30 02:32:17 |
| Message-ID: | 20170530023217.GA139553@gust.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, May 29, 2017 at 03:20:41AM +0000, Tom Lane wrote:
> Annotate the fact that somebody added location fields to PartitionBoundSpec
> and PartitionRangeDatum but forgot to handle them in
> outfuncs.c/readfuncs.c. This is fairly harmless for production purposes
> (since readfuncs.c would just substitute -1 anyway) but it's still bogus.
> It's not worth forcing a post-beta1 initdb just to fix this, but if we
> have another reason to force initdb before 10.0, we should go back and
> clean this up.
+1 for immediately forcing initdb for this, getting it out of the way. We're
already unlikely to reach 10.0 without bumping catversion, but if we otherwise
did, releasing 10.0 with a 10beta1 catversion would have negative value.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-30 02:38:08 | Re: [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp |
| Previous Message | Tom Lane | 2017-05-30 01:48:35 | pgsql: Fix improper quoting of format_type_be() output. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-30 02:38:08 | Re: [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp |
| Previous Message | Tom Lane | 2017-05-30 02:30:18 | Re: PATCH: recursive json_populate_record() |