Re: pg_upgrade translation

Alvaro Herrera wrote:
> Translatability was turned on for pg_upgrade on pg10, but it needs some
> work. The choices are we fix it now, or we revert the addition of NLS
> there and we do it for PG11.

Here are two patches to fix the messages, replacing "new" with "target"
and "old" with "source". I was going to do just the first one
initially, but I figured that the output would become wildly
inconsistent if I stopped at that point.

Now we still have one inconsistency left: the command-line options
--old-bindir --new-datadir etc all contain the words "new" and "old".
Same with a bunch of environment variables. I think the real solution
is that we should change those to --source-bindir and --target-datadir
respectively (and the other ones continue to work for backwards
compatibility), but then maybe leave them alone.

I'll continue fixing things.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services