Re: bumping HASH_VERSION to 3

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bumping HASH_VERSION to 3
Date: 2017-05-21 03:43:51
Message-ID: 20170521034351.GC17369@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 21, 2017 at 09:11:29AM +0530, Amit Kapila wrote:
> On Sun, May 21, 2017 at 5:26 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > On Fri, May 19, 2017 at 04:54:27PM -0400, Robert Haas wrote:
> >> On Tue, May 16, 2017 at 9:25 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >> > On Tue, May 16, 2017 at 5:14 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >> >> On Tue, May 16, 2017 at 7:31 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >> >>> I will send an updated patch once we agree on above points.
> >> >>
> >> >> Sounds good.
> >> >
> >> > Attached patch addresses all the comments as discussed.
> >>
> >> Committed.
> >
> > Just checking, but you reused some of my code from the 8.3-8.4 migration
> > in pg_upgrade that was removed a while back, rather than writing it from
> > scratch, right?
> >
>
> Yes, I have adapted it to what is required for hash indexes, adjusted
> the code for v10 and there are some other minor changes in code.

Great, thanks. It was hard to do originally so I am glad you could
reuse it.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2017-05-21 04:37:26 Re: Race conditions with WAL sender PID lookups
Previous Message Amit Kapila 2017-05-21 03:41:29 Re: bumping HASH_VERSION to 3