| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 10beta1/m68k: static assertion failed: "MAXALIGN too small to fit int32" |
| Date: | 2017-05-18 16:00:42 |
| Message-ID: | 20170518160042.tvojbdqwmzv4xwfn@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-05-18 10:48:48 +0300, Heikki Linnakangas wrote:
> If that's all that prevents it from working, by all means let's fix it. I
> think this should do it, although I don't have a system to test it on:
Yes, that's what I thought about doing too.
> It adds a few instructions to check that on all platforms, unless the
> compiler can optimize that away, but this is not performance critical.
Yea, that seems fairly harmless. Context creation is much more
heavyweight than those 2-3 instructions.
> I'll commit that, barring objections. If you can verify that it fixes the
> problem before that, that'd be great, otherwise I guess we'll find out some
> time after the commit.
lgtm.
Thanks!
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2017-05-18 16:09:03 | Re: [POC] hash partitioning |
| Previous Message | Marina Polyakova | 2017-05-18 16:00:09 | Re: WIP Patch: Precalculate stable functions, infrastructure v1 |