| From: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in ExecModifyTable function and trigger issues for foreign tables |
| Date: | 2017-05-15 09:16:38 |
| Message-ID: | 20170515121638.0c076bcc@wp.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 15 May 2017 10:34:58 +0530
Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
> wrote:
> > After your fix, now tupleid is invalid which is expected, but seems
> > like we need to do something more. As per the comments seems like it
> > is expected to get the oldtuple from planSlot. But I don't see any
> > code for handling that part.
>
> Maybe we should do something like attached patch.
>
Hi,
planSlot contains already projected tuple, you can't use it as oldtuple.
I think problem is that `rewriteTargetListUD` called only for parent
relation, so there is no `wholerow` attribute for foreign tables.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-05-15 09:34:38 | Re: Receive buffer size for the statistics socket |
| Previous Message | Magnus Hagander | 2017-05-15 09:08:19 | Re: Typos in pg_basebackup.c |