| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: WITH clause in CREATE STATISTICS |
| Date: | 2017-05-12 21:44:26 |
| Message-ID: | 20170512214426.sdzcocysfv6ykjjr@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Tom Lane wrote:
> >> Oh, sorry --- I already pushed something about this.
>
> > That's fine, thanks.
>
> Oh, I see your patch also fixes missing code in getObjectDescription().
> We need that. Is there a decent way to get the compiler to warn about
> that oversight?
We could remove the default clause. That results in the expected
warning, and no others (i.e. the switch was already complete):
/pgsql/source/master/src/backend/catalog/objectaddress.c:2657:2: warning: enumeration value 'OCLASS_STATISTIC_EXT' not handled in switch [-Wswitch]
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-12 21:54:40 | Re: WITH clause in CREATE STATISTICS |
| Previous Message | Tom Lane | 2017-05-12 21:35:56 | Re: WITH clause in CREATE STATISTICS |